new $EE tuning thing!

[fbody_Brian]

an observation
when loading multiple log files (appending) if you have already selected items in the graph view they do not update or append the view until you select a different item in that graph. Once you select a new item then the graph extends to include the appended data.

here, the bottom graph shows the whole datalog, whereas the upper graph still shows the previously loaded data.
Attachment 10068

any way to have it replot on loading or appending a log file?
Edit:
Should I be submitting these things as requests/bug reports to github? or is it ok to post in this thread?

[steveo]

when loading multiple log files (appending) if you have already selected items in the graph view they do not update or append the view until you select a different item in that graph

as it stands right now, i expect when new data is added, that the user click the re-plot button themselves to update the graphs.

here, the bottom graph shows the whole datalog, whereas the upper graph still shows the previously loaded data.

having the two graphs out-of-sync due to selecting new data in one graph is certainly a case i didn't think of. i'll likely have to make it refresh BOTH graphs when selecting new data. this isn't a large amount of overhead, as plotting is very fast.

any way to have it replot on loading or appending a log file?

i'd rather force the user to do that manually, otherwise, do i draw the line just at loading a log? what about recording new data?

i originally planned to have to manually refresh all the time, but updating the graphs when selecting data sets was just too useful to pass up.

i want to avoid graphing causing any unintended overhead in the rest of the program. if a user selects a graph item, then goes to load a new log, should he really have to wait extra time for the graph to update?

perhaps i should simply clear the graph when loading new log data or recording new data, but i'd rather leave it plotted as-is

[fbody_Brian]

perhaps i should simply clear the graph when loading new log data or recording new data,

This gets my vote.

As it is now, you can clear the logged data and load a new log yet the graph still shows the previous logs data. If the user is aware of the behavior it's really not a big deal though. it's simple enough to click the replot button.

[steveo]

go grab fresh source from git, i think i fixed the graphing behavior.

it uses a simple 'data stale' state flag, and works on the assumption that data can't be loaded while the graph tab is active, and switching to the graph tab is only done when graphs are desired

it also actually 'clears' the graph when there's no data (before it just bailed if there was no data)

see if you can break it

[fbody_Brian]

it uses a simple 'data stale' state flag, and works on the assumption that data can't be loaded while the graph tab is active, and switching to the graph tab is only done when graphs are desired

I'd say that's a pretty solid assumption.

see if you can break it

I'll try my hardest. I did get the graphing to completely stop working yesterday. I kept loading logs, then playing with max zoom and replotting. at one point i scrolled to an area that didn't have a graph showing, because the graph hadn't been re plotted to reflect loaded log files, I then zoomed in, and when I scrolled back, there was no graph anymore, and no matter what I did it was all just one straight line across the graph. had to restart eehack to get it to work again. In the terminal I had a couple of illegal poly errors, or something similar. I imagine it would be fixed with the latest source, as it was probabably due to the stale graph data

[steveo]

I'll try my hardest. I did get the graphing to completely stop working yesterday. I kept loading logs, then playing with max zoom and replotting. at one point i scrolled to an area that didn't have a graph showing, because the graph hadn't been re plotted to reflect loaded log files, I then zoomed in, and when I scrolled back, there was no graph anymore, and no matter what I did it was all just one straight line across the graph. had to restart eehack to get it to work again. In the terminal I had a couple of illegal poly errors, or something similar. I imagine it would be fixed with the latest source, as it was probabably due to the stale graph data

i doubt it was due to stale data. you load a dataset directly into the plotter, then it becomes independent of the log buffer. pressing 'replot' (or my automatic replotting) is like taking a snapshot of the data to work with.

i'm using a third party plotting library to generate and manage the graphs called qcustomplot. it's very powerful.

there are smaller graphing libraries, and i also wrote my own that worked okay, but i decided to use it so i could take advantage of some other features later.

look at some of the cool shit it can do with your data: http://www.qcustomplot.com/

my two graphs are actually two seperate instances of qcustomplot, but it's capable of doing both graphs as one instance, whiche would be easier to manage. i couldn't get it working (hell i'd only used c++ for a month or two when i started writing this thing) so i just basically added another graph widget and synchronized their time axis during scroll/zoom events.

an illegal poly error is likely a bug in qcustomplot itself, but if we can reproduce it, i can fix it.

[sherlock9c1]

Steveo, I just started using the analysis tools. LOVE them - they look very similar tools I built in Excel to do the same VE and MAF calibration adjustments.

Question - in the Cruising AFR tab, the test vehicle was lean across the board. A few of the cells are green; looks like +5% turns them green? If the meaning of the colors is written into a tooltip, I must have missed it. Can you clarify?