Code: EGR and CTS conversions

[EagleMark]

I dunno what happened. The version I posted was copied directly from TP after confirmed working but this time I couldn't make that one work. This one's working now, $DA = 8.92 deg C.

(-1*.0315*X + 4.5)*(-1*.0315*X + 4.5)*(-1*.0315*X + 4.5)+(X*X*-1*.00045)-(X*.135)+73.00000

Lowest displayed temp should be -34.77 and highest should be 164.13

We have a winner! Sort of... $DA is correct! Minimum and maximum are correct. But the scale is backwards, low is high and high is low...

[1project2many]

That's correct. High temp = low resistance = low counts. Check the lookup table in the disassembly and see what's been staring at us all along. ;)

[EagleMark]

I just haven't had time to look... so it's accurate? Just the slider in TunerPro is backwards?

[gregs78cam]

That's correct. High temp = low resistance = low counts. Check the lookup table in the disassembly and see what's been staring at us all along. ;)

You lost me, what exactly are we looking at?

[1project2many]

Apparently the slider action is backward. Moving it left usually generates a minimum value but for the inverse coolant temp it's backward. But I never looked at the slider. lol... I don't use TP much and I was focused on the equation. Apparently the slider is tied to the hex value rather than the converted value? Unsure if that can be fixed. Uhmmmm.... time for input from the author.

And what this also means is that setting the value to "max" hex actually enabled EGR at the minimum possible temp! 'Splains why I had a vague recollection of having to set this to zero. Too bad I couldn't find anything in my notes to back it up waaay back whe4n this all started.

[EagleMark]

Apparently the slider is tied to the hex value rather than the converted value?

Yes everything is the hex, converted to the value.

What this also means is every temp based on AD lookup in every mask is wrong! Just checked, the slider works right but temp is Max when at Min and Min when at Max!!!

[RobertISaar]

What this also means is every temp based on AD lookup in every mask is wrong!

luckily, it doesn't happen that often.

unluckily, when it does happen, it's usually on the C3s, meaning you can't just change the algorithm in the PROM and have it use the linearized variables.

[gregs78cam]

So, you are saying that the .xdf parameters are wrong in the way they are converting the hex value? Then this is a separate issue from the .adx displaying an inaccurate temp, right?

[EagleMark]

ADX temps are accurate.

All XDF Parameters that use the AD count for temp are wrong until this conversion is installed. They are backwards!

Looks like all temps in dissasembly comments are also way off?

Although this conversion developed here makes the slider in TunerPro operate backwards, the numbers/temps are accurate. Within a few degrees for all the one's I've checked!

[EagleMark]

With this new found, or res-erected and explained info is making sure that temps in dissasembly are marked correctly. If it is 1k pu is it? If it's not marked? Should it be?

[EagleMark]

What this also means is every temp based on AD lookup in every mask is wrong! Just checked, the slider works right but temp is Max when at Min and Min when at Max!!!

I just realized something! This is the reason I had issues with turning off EGR by enable temp and what started this thread!

[jim_in_dorris]

Okay Mark, I guess this means that I can change the comments in the ASDU and ASDX asm files to correct them. I need to look at every place that temp is used and see if it is converted or raw A/D value and make the comment reflect correctly. I am still not convinced that it will solve your EGR problem, but since you apparently have a handle on it now, give it a try. If it still dies, look at fueling. I think you may find the fuel gets cut. Let me know.

[gregs78cam]

ADX temps are accurate.

All XDF Parameters that use the AD count for temp are wrong until this conversion is installed. They are backwards!

Looks like all temps in dissasembly comments are also way off?

Although this conversion developed here makes the slider in TunerPro operate backwards, the numbers/temps are accurate. Within a few degrees for all the one's I've checked!

Just so I have this right, the ADX is fine, but the xdf parameters are backwards because the value that we are changing is the hex value in AD counts which is the inverse of the actual temp. Right?

[EagleMark]

Just so I have this right, the ADX is fine, but the xdf parameters are backwards because the value that we are changing is the hex value in AD counts which is the inverse of the actual temp. Right?

Yes! On ones that are through 1k pup.... but the more I look I think some are also 1k pup and not commented that way. This is all for $42, not sure what the implications are for $0D?

[EagleMark]

Okay Mark, I guess this means that I can change the comments in the ASDU and ASDX asm files to correct them. I need to look at every place that temp is used and see if it is converted or raw A/D value and make the comment reflect correctly. I am still not convinced that it will solve your EGR problem, but since you apparently have a handle on it now, give it a try. If it still dies, look at fueling. I think you may find the fuel gets cut. Let me know.

I'll be testing it on EGR soon. But it's obvious it was being adjusted the wrong way.

I spent a lot of time yesterday with XDF and hack, more questions then answers right now and so many temps have so many different conversions? Commented temps in hack are all over the place. I think most important for accurate temps would be PE enable, DFCO Enable, Hiway LC Enable, Closed Loop Enable. We have EGR enable now that was clearly marked 1k, so maybe that will help track down how other temps are handled? SOme temps should probably never be needed or touched.